Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik, Tarun,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86532?usp=email
to look at the new patch set (#4).
Change subject: soc/intel/common: Refactor FSP-M early Sign-of-Life (SoL) settings ......................................................................
soc/intel/common: Refactor FSP-M early Sign-of-Life (SoL) settings
This commit centralizes the configuration of the Firmware Support Package for Memory (FSP-M) early Sign-of-Life (SoL) into a common function to reduce code duplication and enhance maintainability.
This refactoring aims to improve code readability and reduce potential bugs by having a single source of truth for SoL configuration across different platforms.
Since the Updateable Product Data (UPD) definitions for VGAInitControl differ between Meteor Lake and Panther Lake, and because the list of currently supported uses also varies between the two, the decision-making process is still being conducted within the SoC (System on Chip)-specific codebase.
TEST=FSP-M early SoL functionality was verified on Panther Lake platform.
Change-Id: I03506fbc49ea5b86ce65fe2afbf692b6708a87c5 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/soc/intel/common/Makefile.mk A src/soc/intel/common/fsp_esol.c A src/soc/intel/common/fsp_esol.h M src/soc/intel/meteorlake/romstage/fsp_params.c M src/soc/intel/pantherlake/romstage/fsp_params.c 5 files changed, 46 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/86532/4