Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32047 )
Change subject: soc/apl: Add several audio options to devicetree
......................................................................
Patch Set 4:
Again, why is it useful to set those?
Is there a general rule to have all FSP options be configurable in coreboot? If yes, when updating FSP a corresponding commit should be required in the future?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1522ae81cba5fc08605f4eb349b2977facd3f669
Gerrit-Change-Number: 32047
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 25 Mar 2019 11:43:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment