Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35093 )
Change subject: soc/intel/common: Include cometlake EMMC controller ID
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35093/2/src/include/device/pci_ids....
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35093/2/src/include/device/pci_ids....
PS2, Line 3227: #define PCI_DEVICE_ID_INTEL_CMP_MMC 0x02c4
this could be PCI_DEVICE_ID_INTEL_CMP_EMMC just to make naming consistence across
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008
Gerrit-Change-Number: 35093
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Aug 2019 14:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment