12 Oct
2020
12 Oct
'20
10:41 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45970 )
Change subject: superio/nuvoton/common: Collapse two if statements ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45970/2/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/45970/2/src/superio/nuvoton/common/... PS2, Line 55: if (CONFIG(SUPERIO_NUVOTON_NCT5539D_COM_A) ||
Actually, this should be fixed to not overwrite the entire register contents.
Done in a follow up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45970
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4f787e3c883b1fec941de77bc8e19ccf0d5224c
Gerrit-Change-Number: 45970
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Oct 2020 22:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment