Attention is currently required from: Michael Büchler.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45317 )
Change subject: mb/asrock: Add ASRock H77 Pro4-M mainboard
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File src/mainboard/asrock/h77pro4-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/45317/comment/b504ded5_82f1247d
PS6, Line 73: cpu_fan_header = get_uint_option("cpu_fan_header", CPU_FAN_HEADER_1);
: switch (cpu_fan_header) {
: case CPU_FAN_HEADER_NONE:
: reg = 0xff;
: break;
: case CPU_FAN_HEADER_1:
: reg = 0x7f;
: break;
: case CPU_FAN_HEADER_2:
: reg = 0xbf;
: break;
: case CPU_FAN_HEADER_BOTH:
: reg = 0x3f;
: break;
: }
Glad to hear it! I did the test and it still works as expected. […]
Perfect!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2c51bf7babd9dfcbaf69a5019b2a034762052f2
Gerrit-Change-Number: 45317
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michael Büchler
michael.buechler@posteo.net
Gerrit-Comment-Date: Tue, 07 Dec 2021 10:38:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Büchler
michael.buechler@posteo.net
Gerrit-MessageType: comment