Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35634 )
Change subject: vboot: create board-specific test-only GBB HWID if not set ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... File src/security/vboot/gen_hwid.sh:
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 28: if [ -n "${override}" ]; then
nit: this part would also be easy to do within make (with $(if ...)).
yes but that will make Makefile more complicated. But yes, I can consider that again...
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 38: crc="$(python -c "import zlib, sys; sys.stdout.write(\
IIRC the coreboot build system is not supposed to depend on Python, unless something changed there t […]
That looks horrible. I found a better choice:
https://stackoverflow.com/questions/11553941/use-gunzip-to-calculate-crc32-c...