2 comments:

File src/security/vboot/gen_hwid.sh:
- Patch Set #1, Line 28: if [ -n "${override}" ]; then
  nit: this part would also be easy to do within make (with $(if ...)).
  yes but that will make Makefile more complicated. But yes, I can consider that again...
- Patch Set #1, Line 38: crc="$(python -c "import zlib, sys; sys.stdout.write(\
  IIRC the coreboot build system is not supposed to depend on Python, unless something changed there t […]
  That looks horrible. I found a better choice:
```
 https://stackoverflow.com/questions/11553941/use-gunzip-to-calculate-crc32-code-of-one-string
```

To view, visit change 35634. To unsubscribe, or for help writing mail filters, visit settings.