Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45153 )
Change subject: mb/google/zork:Add dptc interface support
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45153/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45153/6//COMMIT_MSG@12
PS6, Line 12: dptc_enable = 1
: dptc_fast_ppt_limit = 24000
: dptc_slow_ppt_limit = 20000
: dptc_sustained_power_limit = 6000
What variant actually needs this? Instead of adding dptc_enable to 0, can you instead set dptc_enable and the corresponding parameters for that variant in the override tree?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45153
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dac4b7e5157ad7ad407f42a6fc6b06eefbf3291
Gerrit-Change-Number: 45153
Gerrit-PatchSet: 6
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Sep 2020 03:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment