Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp ......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/37ac32eb_eb42c7f5?usp... : PS5, Line 8: #include <fw_config.h>
<*.h> should be separated from ".h" by a blank line. […]
thanks for reminding
https://review.coreboot.org/c/coreboot/+/83287/comment/7e5fb418_f1318594?usp... : PS5, Line 63: fw_config_probe
Align with the fw_config_probe in the previous line.
Using tabs doesn't allow alignment. If I use spaces, Jenkins will prompt.
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/737e49fe_63ccb19e?usp... : PS5, Line 6: #include <fw_config.h>
Same here.
Done
https://review.coreboot.org/c/coreboot/+/83287/comment/89953970_a398a678?usp... : PS5, Line 34: {
Remove `{}`.
Done