Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang.

View Change

4 comments:

• File src/mainboard/google/geralt/chromeos.c:

  • Patch Set #5, Line 8: #include <fw_config.h>

    <*.h> should be separated from ".h" by a blank line. […]

    thanks for reminding

  • Patch Set #5, Line 63: fw_config_probe

    Align with the fw_config_probe in the previous line.

    Using tabs doesn't allow alignment. If I use spaces, Jenkins will prompt.

• File src/mainboard/google/geralt/mainboard.c:

  • Patch Set #5, Line 6: #include <fw_config.h>

    Same here.

    Done

  • Patch Set #5, Line 34: {

    Remove `{}`.

    Done

To view, visit change 83287. To unsubscribe, or for help writing mail filters, visit settings.