Attention is currently required from: Bao Zheng, Marshall Dawson, Nikolai Vyssotski.
Felix Held has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/75682?usp=email )
Change subject: amdfwtool: Add PSP backup directory for A/B recovery
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/75682/comment/cd539053_f04eec34?usp... :
PS6, Line 925: TABLE_ALIGNMENT
should this be TABLE_ALIGNMENT or TABLE_ERASE_ALIGNMENT? recovery_ab implies multi_level and in that case new_psp_dir uses TABLE_ERASE_ALIGNMENT. the resulting code will be identical though, since the value of those two is the same, but it's probably good to use the same define in both places
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75682?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a745c86595554c83cd13a35c312c17987b716b
Gerrit-Change-Number: 75682
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 11 Sep 2024 15:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes