Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38994 )
Change subject: soc/intel/xeon_sp: Enable LPC generic IO decode range ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38994/2/src/soc/intel/xeon_sp/bootb... File src/soc/intel/xeon_sp/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38994/2/src/soc/intel/xeon_sp/bootb... PS2, Line 55: pch_early_iorange_init(); do you plan on adding more stuff into bootblock/pch.c ? if no then please just call pch_enable_lpc() directly and drop pch.c file