Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32293 )
Change subject: smbios: Add memory type 9 system slot support ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
looks good so far. I was thinking about a adding SMBIOS slot description to the devicetree.cb and parse it here to have a platform independent solution (for PCI slots).
https://review.coreboot.org/#/c/32293/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32293/1/src/arch/x86/smbios.c@831 PS1, Line 831: const char *name, u8 type, u8 slot_char1, make attributes const and use enums defined in smbios.h
https://review.coreboot.org/#/c/32293/1/src/arch/x86/smbios.c@849 PS1, Line 849: t->device_function_number = dev_func; missing:
data_bus_width segment_group_number current_usage slot_id