Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42782 )
Change subject: mb/amd/mandolin/devicetree: disable unused internal ethernet controllers
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/...
File src/mainboard/amd/mandolin/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/...
PS1, Line 62: Ethernet
This device is an Ethernet MAC that relies on an external PHY, right?
It's an Ethernet MAC and for connecting to things, you typically need some sort of external PHY. To connect to some sort of backplane you might not need a PHY; haven't really looked into that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4c7ec02f37b35bbc36d40bb937b962cc6413d17
Gerrit-Change-Number: 42782
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 14:04:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment