Attention is currently required from: Tim Wawrzynczak, Robert Chen, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63112 )
Change subject: mb/google/dedede/var/lantis: Add FW_CONFIG probe for EXT_VR
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/dedede/variants/lantis/ramstage.c:
https://review.coreboot.org/c/coreboot/+/63112/comment/23dd1050_f3b1f50a
PS3, Line 10: EXT_VR
Is it part of FW_CONFIG (0 - 31 bits) or SSFC (32 - 63 bits)? Depending on that, you may have to update the overridetree as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d8eec1d2f962d42f3be225eef8498e8b722aace
Gerrit-Change-Number: 63112
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 16:00:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment