Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40322 )
Change subject: soc/amd/picasso: Cleanup legacy UART config ......................................................................
Patch Set 2: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/40322/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40322/2//COMMIT_MSG@7 PS2, Line 7: Cleanup Clean up
https://review.coreboot.org/c/coreboot/+/40322/2//COMMIT_MSG@9 PS2, Line 9: Cleaned Clean up
https://review.coreboot.org/c/coreboot/+/40322/2//COMMIT_MSG@10 PS2, Line 10: Added Add
https://review.coreboot.org/c/coreboot/+/40322/2//COMMIT_MSG@18 PS2, Line 18: BUG=b:143283592 nit: Are the two bug IDs intended to be here? I've no idea of what they are about
https://review.coreboot.org/c/coreboot/+/40322/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40322/2/src/soc/amd/picasso/Kconfig... PS2, Line 169: uart UART
https://review.coreboot.org/c/coreboot/+/40322/2/src/soc/amd/picasso/uart.c File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/40322/2/src/soc/amd/picasso/uart.c@... PS2, Line 42: double empty line