Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35612 )
Change subject: mb/google/kukui: Extend FMAP to 8MB layout
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35612/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35612/4//COMMIT_MSG@9
PS4, Line 9: 8K
8 MB?
Done
https://review.coreboot.org/c/coreboot/+/35612/4/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/35612/4/src/mainboard/google/kukui/...
PS4, Line 4: # RO_FRID, RW_FWID*, GBB, or any unused / padding / CBFS type sections.
Remove the leading space?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id342d57dc95c6197d05b8a265742a2866c35ae09
Gerrit-Change-Number: 35612
Gerrit-PatchSet: 6
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Assignee: Julius Werner
jwerner@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Ho
Ben.Ho@mediatek.com
Gerrit-CC: Julius Werner
jwerner@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-CC: You-Cheng Syu
youcheng@google.com
Gerrit-Comment-Date: Mon, 30 Sep 2019 13:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment