[coreboot-gerrit] Change in ...coreboot[master]: commonlib/stdlib.h: Remove printf() from coreboot

[Julius Werner (Code Review)]

Hello Patrick Rudolph,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/32857

to review the following change.

Change subject: commonlib/stdlib.h: Remove printf() from coreboot
......................................................................

commonlib/stdlib.h: Remove printf() from coreboot

coreboot should not have a definition of printf() anywhere -- it's too
easy to accidentally sneak it into code otherwise. Where that is needed
in code shared with userspace utilities, we should instead use printk()
and define a shim for that for the userspace side.

Change-Id: Iaa459df7122c88beb56695eee7c252d90bbde861
Signed-off-by: Julius Werner 
---
M src/commonlib/include/commonlib/stdlib.h
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/32857/1

diff --git a/src/commonlib/include/commonlib/stdlib.h b/src/commonlib/include/commonlib/stdlib.h
index 1a05eeb..4a3671c 100644
--- a/src/commonlib/include/commonlib/stdlib.h
+++ b/src/commonlib/include/commonlib/stdlib.h
@@ -38,11 +38,11 @@
 #if CONFIG(COREBOOT_BUILD)
 #include <console/console.h>
 #include <halt.h>
-#define printf(...)		printk(BIOS_ERR, __VA_ARGS__)
 #define HALT(x)			halt()
 #else
 #include <stdio.h>
-#define HALT(x)
+#define printk(level, ...)	printf(__VA_ARGS__)
+#define HALT(x)			abort()
 #endif

static inline void *xmalloc_work(size_t size, const char *file,
@@ -50,7 +50,7 @@
 {
    void *ret = malloc(size);
    if (!ret && size) {
-		printf("%s/%s/line %d: Failed to malloc %zu bytes\n",
+		printk(BIOS_ERR, "%s/%s/line %d: Failed to malloc %zu bytes\n",
    		file, func, line, size);
    	while (1)
    		HALT(1);