Name of user not set #1002873 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40539 )
Change subject: tests: Add device/i2c-test test case ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40539/1/tests/device/i2c-test.c File tests/device/i2c-test.c:
https://review.coreboot.org/c/coreboot/+/40539/1/tests/device/i2c-test.c@36 PS1, Line 36: {0, 0xA, { /* bus, slave */
nit: Rather than comments, we usually make struct initializers more readable like this: […]
Will fix this in next version. I'm also adding an additional change with removal of unnecessary code. See comment below.
https://review.coreboot.org/c/coreboot/+/40539/1/tests/device/i2c-test.c@154 PS1, Line 154: i2c_read_field(i2c_ex_devs[i].bus, : i2c_ex_devs[i].slave, : i2c_ex_devs[i].regs[j].reg, : &buf, MASK, SHIFT); : }; This block is actually unused here. Should have removed this during cleanup. Will fix in v4.