Hello Iru Cai,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/30889
to review the following change.
Change subject: autoport: move the generated gnvs.c to acpi_tables.c ......................................................................
autoport: move the generated gnvs.c to acpi_tables.c
Change-Id: I8f6eea579f69060608639b1c50255acd8ab5a4a2 Signed-off-by: Iru Cai mytbk920423@gmail.com --- M util/autoport/bd82x6x.go M util/autoport/main.go 2 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/30889/1
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 887a520..eef0eb7 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -391,7 +391,7 @@ } sb.WriteString("}\n")
- gnvs := Create(ctx, "gnvs.c") + gnvs := Create(ctx, "acpi_tables.c") defer gnvs.Close()
Add_gpl(gnvs) @@ -416,7 +416,6 @@ } `)
- AddRAMStageFile("gnvs.c", "") }
func init() { diff --git a/util/autoport/main.go b/util/autoport/main.go index ee26966..05a829b 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -789,10 +789,6 @@ } }
- at := Create(ctx, "acpi_tables.c") - defer at.Close() - at.WriteString("/* dummy */\n") - bi := Create(ctx, "board_info.txt") defer bi.Close()