Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33839 )
Change subject: mb/protectli/vault_kbl: Add FW6 support ......................................................................
Patch Set 10:
(6 comments)
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... File Documentation/mainboard/protectli/fw6.jpg:
PS8:
Yes, I guess
Done
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... File Documentation/mainboard/protectli/fw6.md:
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... PS8, Line 28: microcode
Capitalize?
Done
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... PS8, Line 31: graphics in BIOS
It should be SeaBIOS or a pre-OS. […]
Done
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... PS8, Line 38: The first supported
missing rest of sentence
Done
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau... File src/mainboard/protectli/vault_kbl/Kconfig:
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau... PS8, Line 5: select BOARD_ROMSIZE_KB_8192 : select HAVE_ACPI_RESUME : select HAVE_ACPI_TABLES : select SOC_INTEL_KABYLAKE : select SUPERIO_ITE_IT8772F : select MAINBOARD_HAS_LIBGFXINIT : select SEABIOS_ADD_SERCON_PORT_FILE if PAYLOAD_SEABIOS : select SPI_FLASH_MACRONIX
alphabetize?
Done
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau... File src/mainboard/protectli/vault_kbl/acpi_tables.c:
PS8:
This can go away
Done