[coreboot-gerrit] Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: set a board type to AMD_PLATFORM_DESKTOP

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33919 )

Change subject: mb/asus/am1i-a/buildOpts.c: set a board type to AMD_PLATFORM_DESKTOP
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33919/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33919/6//COMMIT_MSG@9 
PS6, Line 9: Original AMD_PLATFORM_MOBILE is incorrect because this board is a desktop one.
> If this is incorrect, what does changing it improve?

There is AMD vendorcode which is active only if AMD_PLATFORM_MOBILE is enabled:

./src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbInitKB/GfxIntegratedInfoTableKB.c:467:        // GPUCAPINFO_DFS_BYPASS_ENABLE should be enabled by default for MOBILE systems
    if ((Gfx->AmdPlatformType & AMD_PLATFORM_MOBILE) != 0) {
      SystemInfoTableV3.sIntegratedSysInfo.ulGPUCapInfo |= GPUCAPINFO_DFS_BYPASS_ENABLE;
    }

./src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbPcieConfig/PcieConfigData.c:253:    if ((UserOptions.CfgAmdPlatformType  & AMD_PLATFORM_MOBILE) != 0) {
    Pcie->GfxCardWorkaround = GfxWorkaroundDisable;
  }

./src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbGfxIntTableV3/GfxPwrPlayTable.c:1058:    if ((Gfx->AmdPlatformType & AMD_PLATFORM_MOBILE) != 0) {
    PpWorkspace.PpTable->ulPlatformCaps |= ATOM_PP_PLATFORM_CAP_POWERPLAY;
  }