John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46506 )
Change subject: drivers/uart: Fix control flow DEADCODE issue ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46506/1/src/drivers/uart/acpi/acpi.... File src/drivers/uart/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/46506/1/src/drivers/uart/acpi/acpi.... PS1, Line 78: irq_gpio_index++;
Why increment it?
The irq_gpio_index increment is similar to reset_gpio_index and enable_gpio_index handling in uart_acpi_write_gpio as long as gpio->pin_count is not 0.
https://review.coreboot.org/c/coreboot/+/46506/1/src/drivers/uart/acpi/acpi.... PS1, Line 80: else
The `else` should have braces too.
Ack