Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29345 )
Change subject: soc/amd/stoneyridge: Get rid of domain_read_resources
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29345/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29345/1//COMMIT_MSG@24
PS1, Line 24: the empty resource
The particular empty resource was filled later:
DOMAIN: 0000 10000000 <- [0x0000001000 - 0x00000010ff] size 0x00000100 gran 0x00 io
DOMAIN: 0000 10000100 <- [0x00f0000000 - 0x00f4d8a0ff] size 0x04d8a100 gran 0x00 mem
Have you check if it's still being created? Or if not being created, does it affects the boot process anyway (it might be created and never used)?
--
To view, visit
https://review.coreboot.org/29345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83bd3ea8db141416632c12fc883386070363f2f1
Gerrit-Change-Number: 29345
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Oct 2018 22:53:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No