Martin Roth has posted comments on this change. ( https://review.coreboot.org/28956 )
Change subject: src: Standardize PCI_DEV(0, 0x1f, 0) name ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/28956/5/src/southbridge/intel/bd82x6x/pch.h File src/southbridge/intel/bd82x6x/pch.h:
https://review.coreboot.org/#/c/28956/5/src/southbridge/intel/bd82x6x/pch.h@... PS5, Line 133: LPC_DEV PCI_DEV(0, 0x1f, 0) But now this doesn't match all of the other #defines for the platform. We have the same issue on many other platforms. I appreciate the effort, but I'm not positive it makes sense to try to standardize it across all platforms.
Are we going to standardize all of the others as well?