Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39287 )
Change subject: vendorcode/intel/fsp/fsp2_0/skylake_sp: update header files ......................................................................
Patch Set 1:
(4 comments)
Hi Paul/Patrick/Reddy,
Thanks for Paul's review. He raised questions about the license statements. These FSP header files are of Intel license. They are provided by Intel as-is. My understanding is that code in vendorcode directory do not necessarily have to be 100% coreboot style.
Jonathan
https://review.coreboot.org/c/coreboot/+/39287/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39287/1//COMMIT_MSG@9 PS1, Line 9: Added
Present tense.
Done
https://review.coreboot.org/c/coreboot/+/39287/1//COMMIT_MSG@11 PS1, Line 11: Added
Present tense.
Done
https://review.coreboot.org/c/coreboot/+/39287/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/skylake_sp/gpio_fsp.h:
https://review.coreboot.org/c/coreboot/+/39287/1/src/vendorcode/intel/fsp/fs... PS1, Line 2: Copyright (c) 2019-2020, Intel Corporation. All rights reserved.<BR>
Remove the <BR> at the end.
This is part of standard Intel license message. It is a doxygen mark. The files in src/vendorcode directory are from vendors, based on vendor format. They do not necessarily have to be 100% coreboot format.
https://review.coreboot.org/c/coreboot/+/39287/1/src/vendorcode/intel/fsp/fs... PS1, Line 28: **/
Make this a standard header license comment (asterisks in the beginning)? […]
These header files are Intel FSP header files, they are delivered into coreboot as part of FSP. Their license is Intel license.