build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30432 )
Change subject: drivers/smmstore: Fix some issues ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/#/c/30432/7/src/drivers/smmstore/store.c File src/drivers/smmstore/store.c:
https://review.coreboot.org/#/c/30432/7/src/drivers/smmstore/store.c@193 PS7, Line 193: if (boot_device_rw_subregion(region_device_region(&store), &store) < 0) { line over 80 characters
https://review.coreboot.org/#/c/30432/7/src/drivers/smmstore/store.c@200 PS7, Line 200: .size = sizeof(key_sz) + sizeof(value_sz) + key_sz + value_sz + 1, line over 80 characters
https://review.coreboot.org/#/c/30432/7/src/drivers/smmstore/store.c@208 PS7, Line 208: if (rdev_writeat(&store, &key_sz, end, sizeof(key_sz)) != sizeof(key_sz)) { line over 80 characters
https://review.coreboot.org/#/c/30432/7/src/drivers/smmstore/store.c@208 PS7, Line 208: if (rdev_writeat(&store, &key_sz, end, sizeof(key_sz)) != sizeof(key_sz)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/30432/7/src/drivers/smmstore/store.c@212 PS7, Line 212: if (rdev_writeat(&store, &value_sz, end, sizeof(value_sz)) != sizeof(key_sz)) { line over 80 characters
https://review.coreboot.org/#/c/30432/7/src/drivers/smmstore/store.c@212 PS7, Line 212: if (rdev_writeat(&store, &value_sz, end, sizeof(value_sz)) != sizeof(key_sz)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/30432/7/src/drivers/smmstore/store.c@225 PS7, Line 225: if (rdev_writeat(&store, &nul, end, sizeof(nul)) != sizeof(nul)) { braces {} are not necessary for single statement blocks