Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support
......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded...
PS23, Line 284: GPP_G7
Thanks Aamir! I still don't understand why the WP creates problems only at init time. […]
ok, yes. based on current observations the NF configuration seems to be must for resolving the dmesg errors.
Below are still open:
1. Does controller expects to be configured WP as NF, even if not connected.
2. Why are tranfer request not getting completed and card status is set busy with NC configuration.
We can update the bug based on the findings.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39237
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c8ceb85ada23718ff7b6fd7013317c818dd532
Gerrit-Change-Number: 39237
Gerrit-PatchSet: 28
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 May 2020 05:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment