3 May
2019
3 May
'19
6:47 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32530 )
Change subject: drivers/intel/fsp2_0: Fix fsp post-init validation ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32530/7/src/drivers/intel/fsp2_0/memory_init... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/#/c/32530/7/src/drivers/intel/fsp2_0/memory_init... PS7, Line 322: fsp_debug_after_memory_init Maybe add a comment here indicating why this is required after do_fsp_post_memory_init() so future change does not end up moving it again?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib89e0513bdc35c3751a9d4c2a2789a2836046789
Gerrit-Change-Number: 32530
Gerrit-PatchSet: 7
Gerrit-Owner: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Naresh Solanki naresh.solanki@intel.com
Gerrit-CC: Nathaniel L Desimone nathaniel.l.desimone@intel.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Pratikkumar V Prajapati pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Fri, 03 May 2019 16:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment