Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37285 )
Change subject: mb/lenovo/t420s/devicetree: Use subsystemid inheritance
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/...
File src/mainboard/lenovo/t420s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/...
PS1, Line 2: # IGD Displays
Um, let me rephrase: this is not mentioned in the commit message, so it struck as odd. […]
Removed added comment here.
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/...
PS1, Line 73: # device specific SPI configuration
This one as well
Removed added commend here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37285
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia77f0ce89b2234b9c164bb326d76bef98949832a
Gerrit-Change-Number: 37285
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 01 Dec 2019 08:26:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment