Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38883 )
Change subject: mb/apple: Add iMac13,1 (21.5-inch, Late 2012) ......................................................................
Patch Set 1:
(7 comments)
Very nice.
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG@23 PS1, Line 23: How did you create the port?
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG@41 PS1, Line 41: which had issues with headphones Any reference?
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG@41 PS1, Line 41: Cirrrrrus Just Cirrus for when searching commits for that vendor.
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG@49 PS1, Line 49: a an
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG@50 PS1, Line 50: - Booting enough to use SSH via Ethernet What payload, and what Linux kernel?
https://review.coreboot.org/c/coreboot/+/38883/1/src/mainboard/apple/imac13_... File src/mainboard/apple/imac13_1/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38883/1/src/mainboard/apple/imac13_... PS1, Line 2: Late Lowercase?
https://review.coreboot.org/c/coreboot/+/38883/1/src/mainboard/apple/imac13_... File src/mainboard/apple/imac13_1/early_init.c:
https://review.coreboot.org/c/coreboot/+/38883/1/src/mainboard/apple/imac13_... PS1, Line 43: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f); Add a comment what this does?