[coreboot-gerrit] Change in ...coreboot[master]: mediatek: Refactor I2C code among similar SOCs

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30975 )

Change subject: mediatek: Refactor I2C code among similar SOCs
......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/#/c/30975/12/src/soc/mediatek/common/i2c.c 
File src/soc/mediatek/common/i2c.c:

https://review.coreboot.org/#/c/30975/12/src/soc/mediatek/common/i2c.c@156 
PS12, Line 156: ASYNC_MODE | DMAACK_EN |
These two flags are new here. Why?

https://review.coreboot.org/#/c/30975/12/src/soc/mediatek/mt8173/i2c.c 
File src/soc/mediatek/mt8173/i2c.c:

https://review.coreboot.org/#/c/30975/12/src/soc/mediatek/mt8173/i2c.c@83 
PS12, Line 83: static inline void i2c_dma_reset(struct mt_i2c_dma_regs *dma_regs)
Unused now?