Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31772 )
Change subject: Grunt platforms: Change bayhub BH720 eMMC speed to 200 MHz ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/31772/2/src/commonlib/storage/pci_sdhci.c File src/commonlib/storage/pci_sdhci.c:
https://review.coreboot.org/#/c/31772/2/src/commonlib/storage/pci_sdhci.c@60 PS2, Line 60: bh720_tuning_start the bayhub functions should go into the bayhub directory.
https://review.coreboot.org/#/c/31772/2/src/commonlib/storage/pci_sdhci.c@10... PS2, Line 102: else Please put braces around the udelay so that both sides of the else match. Checkpatch might not like it, but sometimes checkpatch is stupid.
https://review.coreboot.org/#/c/31772/2/src/commonlib/storage/pci_sdhci.c@12... PS2, Line 121: after you move the functions above, this should get protected by a config option so that it only gets called if the bayhub part is enabled.
https://review.coreboot.org/#/c/31772/2/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/#/c/31772/2/src/mainboard/google/kahlee/variants... PS2, Line 64: /* Set Bayhub SD base CLK 200MHz */ Put this change in a separate commit please.