[coreboot-gerrit] Change in coreboot[master]: ec/google/wilco: Set cpu id and cores to EC

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38566 )

Change subject: ec/google/wilco: Set cpu id and cores to EC
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/38566/2/src/mainboard/google/dralli... 
File src/mainboard/google/drallion/ramstage.c:

https://review.coreboot.org/c/coreboot/+/38566/2/src/mainboard/google/dralli... 
PS2, Line 69: 	uint16_t mch_id = 0;
> Initialization not needed.

Done

https://review.coreboot.org/c/coreboot/+/38566/2/src/mainboard/google/dralli... 
PS2, Line 70: cpu_cores
> Oh, I can pass the pointer to get the cores. I will check it, thanks.

This function is works. And the virtual one will include all cores, ex: 4+2 will get 8 cores.

https://review.coreboot.org/c/coreboot/+/38566/2/src/mainboard/google/dralli... 
PS2, Line 88: 		printk(BIOS_ERR, "wilco set cpu id failed\n");
> Error messages should be more elaborate for users. […]

Done