build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44669 )
Change subject: tests: Add lib/imd-test test case ......................................................................
Patch Set 3:
(12 comments)
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c File tests/lib/imd-test.c:
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@49 PS3, Line 49: 0xA000, /* Fits in 16 bits, should not get rounded down*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@50 PS3, Line 50: 0xDEAA, /* Fits in 16 bits */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@51 PS3, Line 51: 0xB0B0B000, /* Fits in 32 bits, should not get rounded down */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@52 PS3, Line 52: 0xF0F0F0F0, /* Fits in 32 bits */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@54 PS3, Line 54: 0x6666777788889000, /* Fits in 64 bits, should not get rounded down */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@55 PS3, Line 55: ((1ULL << 60) - 100) /* Very large address still fitting in 64-bit address space */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@123 PS3, Line 123: assert_int_equal(-1, imd_create_empty(&imd, sizeof(struct imd_root_pointer), LG_ENTRY_ALIGN)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@255 PS3, Line 255: assert_int_equal(2, ((struct imd_root*)imd.lg.r)->num_entries); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@256 PS3, Line 256: assert_int_equal(1, ((struct imd_root*)imd.sm.r)->num_entries); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@284 PS3, Line 284: assert_int_equal(2, ((struct imd_root*)imd.sm.r)->num_entries); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@325 PS3, Line 325: max_size = align_up_pow2(sizeof(struct imd_root_pointer) + sizeof(struct imd_root) + 3 * sizeof(struct imd_entry)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/44669/3/tests/lib/imd-test.c@334 PS3, Line 334: root_size = align_up_pow2(sizeof(struct imd_root_pointer) + sizeof(struct imd_root) + 2 * sizeof(struct imd_entry)); line over 96 characters