Attention is currently required from: Mario Scheithauer, Angel Pons, Arthur Heymans, Lean Sheng Tan.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69383 )
Change subject: soc/intel/ehl: Add MDIO operation to TSN GbE device ......................................................................
Patch Set 10: Code-Review+1
(4 comments)
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/69383/comment/5e27aa9a_6abc6ff1 PS10, Line 42: printk(BIOS_ALERT, "MDIO bus operations not available for %s.\n", : dev_path(dev)); There is a message on ERROR level already in dev_get_mdio_ops() (see https://review.coreboot.org/c/coreboot/+/69382/6/src/device/mdio.c) for this case. Does it make sense to print yet another one with a different log level?
https://review.coreboot.org/c/coreboot/+/69383/comment/ea90f55c_18c35624 PS10, Line 94: Add a mdelay(1); here so that this time can be used elsewhere if needed? See src/lib/thread.c for the thread_yield-functions.
https://review.coreboot.org/c/coreboot/+/69383/comment/eda6eeb5_2605ad2f PS10, Line 128: static void tsn_mdio_write(struct device *dev, uint8_t phy_adr, uint8_t reg_adr, : uint16_t data) Looks like this could fit on one line (95 chars).
https://review.coreboot.org/c/coreboot/+/69383/comment/2b6f5069_a63ebae1 PS10, Line 143: do next exit