Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35993 )
Change subject: cpu/x86: Add a prog_run hook to set up caching of XIP stages ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35993/5/src/cpu/x86/mtrr/xip_cache.... File src/cpu/x86/mtrr/xip_cache.c:
https://review.coreboot.org/c/coreboot/+/35993/5/src/cpu/x86/mtrr/xip_cache.... PS5, Line 48: base = ALIGN_DOWN(base, mtrr_mask_size);
Move below the `if`, so we don't align down too far in the >max case? […]
Done
https://review.coreboot.org/c/coreboot/+/35993/6/src/cpu/x86/mtrr/xip_cache.... File src/cpu/x86/mtrr/xip_cache.c:
https://review.coreboot.org/c/coreboot/+/35993/6/src/cpu/x86/mtrr/xip_cache.... PS6, Line 59: mtrr_base = ALIGN_UP(base, mtrr_mask_size); Still, I think we need to override the ALIGN_DOWN() above.
else mtrr_base = ALIGN_DOWN(base, mtrr_mask_size);