Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41612 )
Change subject: util/mb/google: Add spd_tools to generate SPDs for TGL boards ......................................................................
Patch Set 2:
(4 comments)
Please add it under top level `util`.
Does the coreboot SDK need to be updated to provide a Go lang toolchain?
https://review.coreboot.org/c/coreboot/+/41612/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41612/2//COMMIT_MSG@12 PS2, Line 12: recommendations(doc #616599) Please add a space.
https://review.coreboot.org/c/coreboot/+/41612/2/util/mainboard/google/spd_t... File util/mainboard/google/spd_tools/lp4x/README.md:
https://review.coreboot.org/c/coreboot/+/41612/2/util/mainboard/google/spd_t... PS2, Line 4: Intel Tiger Lake(TGL) Please add a space before (.
https://review.coreboot.org/c/coreboot/+/41612/2/util/mainboard/google/spd_t... PS2, Line 6: recommendations(doc #616599) Ditto.
https://review.coreboot.org/c/coreboot/+/41612/2/util/mainboard/google/spd_t... PS2, Line 134: ``` If possible, just indent code blocks by four spaces instead of using ```.