Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39345 )
Change subject: mb/google/volteer: Enable DPTF functionality
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39345/5/src/mainboard/google/voltee...
File src/mainboard/google/volteer/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39345/5/src/mainboard/google/voltee...
PS5, Line 54: baseboard/acpi/dptf.asl
This is still not correct. It should be variant/acpi/dptf.asl like you had before. What my earlier comment meant was you need to add dptf.asl file under variant/volteer and variant/ripto and those boards would include baseboard/acpi/dptf.asl. Please see hatch as example.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd387d78bb45ca3de73f531a901d1d3f793d7bd
Gerrit-Change-Number: 39345
Gerrit-PatchSet: 5
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Thu, 19 Mar 2020 05:35:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment