Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31900 )
Change subject: device: Rename scan_static_bus() -> enable_static_devices() ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31900/2/src/device/root_device.c File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/31900/2/src/device/root_device.c@46 PS2, Line 46: enable_static_devices
If this is really enable devices, then shouldn't it be called as part of enable_dev() and not scan_b […]
It is. scan_bus() actually is supposed to perform both, it first enables all devices on a bus, then descends further via scan_bridges(). However, this implementation here does not descend and I think the name should reflect that.
My goal is to bring all the implementations here, step by step to a single scan_static_bus() that does everything right :) I'm not sure yet what to do with the secondary bus number handling in scan_generic_bus() below. Apart from that everything is straight forward (an additional scan_bridges() doesn't hurt if there are no downstream devices and if there are, it was a bug not to descend).