Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33264
Change subject: nb/amd/amdmct/mct_ddr3: Remove duplicate conditional ......................................................................
nb/amd/amdmct/mct_ddr3: Remove duplicate conditional
This check is already performed at the beginning of dct_ddr_voltage_index().
Change-Id: Ia73025333c152f14249afb16d05f66791e69e7cb Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1347322, 1347323 --- M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33264/1
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index 5be4566..b30a663 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3071,11 +3071,6 @@ */ uint8_t dimm_event_l_pin_support = 0;
- if (pDCTstat->DIMMValidDCT[dct] == 0) - ddr_voltage_index = 1; - else - ddr_voltage_index = dct_ddr_voltage_index(pDCTstat, dct); - ddr_voltage_index = dct_ddr_voltage_index(pDCTstat, dct); max_dimms_installable = mctGet_NVbits(NV_MAX_DIMMS_PER_CH);