Attention is currently required from: Sunwei Li, Henry Sun, Bob Moragues.
Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56658 )
Change subject: mb/google/dedede/var/cappy2: Add Tpm2.0 device support
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/dedede/variants/cappy2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56658/comment/270ab490_c20ca18c
PS4, Line 102: 1f.5
Can we move this to 1f.0? On an earlier variant, we were getting messages in coreboot about the TPM going to the default ACPI address. I think the functionality should still be the same.
"Using default TPM ACPI path: '_SB_.PCI0.LPCB'"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I216ceb6386ad57c9f1982187a4525d89869fa9c4
Gerrit-Change-Number: 56658
Gerrit-PatchSet: 4
Gerrit-Owner: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment