Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, Srinidhi N Kaushik, Raj Astekar, Patrick Rudolph.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49244 )
Change subject: soc/intel/tigerlake: Enable TC Cold support
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49244/comment/b88f35a3_daaa8989
PS3, Line 9: This change enables support for TC cold usb connect.
Can you please add some information as to why this change is required?
Please go over https://chrome-internal-review.googlesource.com/c/chromeos/third_party/intel....
if (TcssPeiConfig->IomConfig.DisableTccoldOnUsbConnected == 0) {
//
// CLEAR BIT 20 of IOM_TYPEC_SW_CONFIGURATION_1
// 0 - Enable TC cold if only have USB2 or lower speed connected.
//
IomTypecConfigValue &= (~DISABLE_TCCOLD_ON_USB_CONNECTED);
} else {
//
// SET BIT 20 of IOM_TYPEC_SW_CONFIGURATION_1
// 1 - Disable TC cold when any USB2/3 device connected.
//
IomTypecConfigValue |= DISABLE_TCCOLD_ON_USB_CONNECTED;
}
DisableTccoldOnUsbConnected=0 -> bit20 is NOT set (TCCold is not disabled)
DisableTccoldOnUsbConnected=1 -> bit21 is set (TCCold is disabled) which what we need to resolve the enumeration issue while plugging this usb3 into typec-to-a dongle.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49244
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ad0322693b4f8fbf1000b24eb21dddcebec686b
Gerrit-Change-Number: 49244
Gerrit-PatchSet: 3
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 12 Jan 2021 04:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment