Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40355 )
Change subject: ec/google/chromeec: add BOARD_VERSION CBI support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40355/1/src/ec/google/chromeec/ec.h
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/40355/1/src/ec/google/chromeec/ec.h...
PS1, Line 82: * handles it correctly. */
Please remove the asterisk in the beginning to use the allowed concise multi-line comment style. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2f289631f908014432596448e56b5048a196a10
Gerrit-Change-Number: 40355
Gerrit-PatchSet: 2
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Apr 2020 13:58:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment