Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48552 )
Change subject: mb/google/octopus/variants/phaser: support new touch panel ic ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@7 PS3, Line 7: variants variants -> var
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@7 PS3, Line 7: support new touch : panel ic Keep it in single line. Also mention as "Add support for G2TOUCH Touchscreen"
https://review.coreboot.org/c/coreboot/+/48552/3//COMMIT_MSG@10 PS3, Line 10: This is a new G2Touch screen IC, enable touch screen, : and ensure it works properly. Add devicetree configuration for G2TOUCH Touchscreen controller.
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48552/3/src/mainboard/google/octopu... PS3, Line 182: register "generic.reset_delay_ms" = "70"
- Then please at least add disable_gpio_export_in_crs back to the CL. […]
Since this comment is not resolved, I am re-opening it.