[coreboot-gerrit] Change in coreboot[master]: mrc_cache: Update mrc_cache data in romstage

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )

Change subject: mrc_cache: Update mrc_cache data in romstage
......................................................................

Patch Set 25:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44196/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44196/8//COMMIT_MSG@16 
PS8, Line 16: Updating spi driver Kconfig to set
            : BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY=y if both
            : BOOT_DEVICE_SPI_FLASH_RW_NOMMAP=y and BOOT_DEVICE_SPI_FLASH=y to bring
            : the appropriate libraries into romstage.
> Thanks. In the meantime: tested flash console on ICH9-M, looks perfect […]

Thanks for testing this out Nico! This is very helpful.

If we don't really have problems with writing to flash in early stages on any platform, then I think we should deprecate BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY. We can also send out a PSA on the mailing list to indicate that this change is coming up and ensure it doesn't cause silent regressions for anyone.

Let's wait for feedback on ICH7 and also to hear back from Duncan/Subrata.