Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35004 )
Change subject: x86: Introduce RESET_VECTOR_IN_RAM option ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35004/10/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/35004/10/src/Kconfig@155 PS10, Line 155: config RESET_VECTOR_IN_RAM
Can't this go in src/arch/x86/Kconfig?
It can, if we feel no other arch would soon use it. Do you want it named _RAM or _DRAM? I had suggested the former, Marshall chose the latter.
https://review.coreboot.org/c/coreboot/+/35004/10/src/arch/x86/memlayout.ld File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/35004/10/src/arch/x86/memlayout.ld@... PS10, Line 20: #if ENV_ROMSTAGE_OR_BEFORE
Why not &&?
I would hit #error below for every !ENV_ROMSTAGE_OR_BEFORE ?