1 May
2019
1 May
'19
11:38 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32515 )
Change subject: purism/librem_skl: remove 13v3 target, clean up Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32515/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32515/2//COMMIT_MSG@15 PS2, Line 15: - remove redundant MAINBOARD_VERSION option
It's used to fill the SMBIOS table. Just seems odd to […]
it should default to 1.0 per src/Kconfig, since no longer being overridden by mainboard
--
To view, visit https://review.coreboot.org/c/coreboot/+/32515
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic09b8ec5c576f4c4c48ef30ee3f60a4c2c286cd3
Gerrit-Change-Number: 32515
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Wed, 01 May 2019 21:38:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment