Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33774 )
Change subject: sb/amd/sb{700,800}: Cleanup index manipulations ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb700/sb700.c File src/southbridge/amd/sb700/sb700.c:
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb700/sb700.c@a1... PS1, Line 107:
why it is set = -1 ?
No need to initialize it here.
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb700/sb700.c@15... PS1, Line 156: return; I wonder what this was supposed to do.
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb800/sb800.c File src/southbridge/amd/sb800/sb800.c:
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb800/sb800.c@a2... PS1, Line 231:
out of topic, but why "-1" ?
No need and it's not out of topic to remove it.
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb800/sb800.c@a3... PS1, Line 340: No need to keep this either.
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb800/sb800.c@31... PS1, Line 311: index = (dev->path.pci.devfn & 0x3) / 2; The case has even devfn of 12.0 or 12.2, it's fine.