Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46393 )
Change subject: soc/mediatek/mt8192: Add dpm loader
......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46393/28/src/soc/mediatek/mt8192/dp...
File src/soc/mediatek/mt8192/dpm.c:
https://review.coreboot.org/c/coreboot/+/46393/28/src/soc/mediatek/mt8192/dp...
PS28, Line 25:
: dm_file_bytes = cbfs_boot_load_file(dm_file_name, dpm_dm_bin,
: sizeof(dpm_dm_bin), CBFS_TYPE_RAW);
: if (dm_file_bytes == 0) {
: printk(BIOS_ERR, "binary %s not found\n", dm_file_name);
: return -1;
: }
:
: pm_file_bytes = cbfs_boot_load_file(pm_file_name, dpm_pm_bin,
: sizeof(dpm_pm_bin), CBFS_TYPE_RAW);
: if (pm_file_bytes == 0) {
: printk(BIOS_ERR, "binary %s not found\n", pm_file_name);
: return -2;
: }
why can't we use the ocmmon API?
I will squash CB:46932 into this patch in next patchset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16b341ad63940b45b886c4a7fd733c1970624e40
Gerrit-Change-Number: 46393
Gerrit-PatchSet: 28
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 20 Nov 2020 10:09:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment